Allow wrapping selection off top/bottom of autocomplete results
AbandonedPublic

Authored by cullmann on May 9 2018, 12:13 AM.

Details

Reviewers
sraizada
Group Reviewers
KTextEditor
Summary

When at the first autocomplete result, pressing up will wrap around to the last result, and vice versa.

This does make test 56 (completion_test) fail with an "Exception: Child aborted" - I'm looking into it.

Diff Detail

Repository
R39 KTextEditor
Lint
Lint Skipped
Unit
Unit Tests Skipped
sraizada created this revision.May 9 2018, 12:13 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMay 9 2018, 12:13 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
sraizada requested review of this revision.May 9 2018, 12:13 AM
sraizada added a project: KTextEditor.
sraizada added a subscriber: KTextEditor.
brauch added a subscriber: brauch.May 9 2018, 7:14 AM

What happens if the overload selection window is open in addition (like in KDevelop)?

sraizada updated this revision to Diff 33884.May 9 2018, 1:23 PM

Removed unnecessary modifications to code

Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. · View Herald TranscriptMay 9 2018, 1:23 PM

I only use Kate/KWrite so didn't test it on the others previously - sorry.
It actually only works in Kate and KWrite, and has no effect on Kile/KDevelop. KDevelop is obviously doing some special stuff, but visually the Kile autocompletion seems identical to the one in Kate/KWrite so I'm surprised that it doesn't work.
Any idea what's causing this issue or where I should look in the KDevelop code?

I remember that @cullmann intentionally implemented it this way: Going upwards will hide the completion list and not wrap around.

@cullmann Any take on this? Either accept, or reject.

Also, the unit test need fixing obviously...

I think the idea was that it is an easy way out of the completion.
I am not sure if wrapping is what one would expect.

Indeed, question is if wrapping helps: If you see 5 entries, and you see the last one is correct, then moving up would be ok.
But if the completion contains >> 10 entries, this will not work. And then, there is still the "End" key on the keyboard as dedicated action.

cullmann commandeered this revision.Aug 14 2018, 9:30 PM
cullmann added a reviewer: sraizada.

I don't think such a behavior change is wanted.

cullmann abandoned this revision.Aug 14 2018, 9:30 PM