Use a more intuitive, user-friendly name for Samba share access
ClosedPublic

Authored by ngraham on May 8 2018, 8:08 PM.

Details

Summary

"Samba shares" is a jargonistic term that won't mean much to most people. This patch replaces it with a more intuitive and user-friendly term.

BUG: 141257
FIXED-IN: 18.08.0

Test Plan

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.May 8 2018, 8:08 PM
ngraham created this revision.
ngraham edited the test plan for this revision. (Show Details)May 8 2018, 8:09 PM

If we remove Samba, how do people who know Samba find where Samba is?

Maybe we can use "Samba Shared Folders" ?

"Shared folders (Samba)"?

Then again, I doubt that people who know what Samba is will have difficulty figuring out that "Shared folders" under the "Network" Place is where Samba shares live.

or "Shared folders (SMB)", as the protocol is probably more relevant.

Sounds good to me!

ngraham updated this revision to Diff 33844.May 8 2018, 9:08 PM

Add the protocol acronym to help tech-savvy users know what they're looking at

ngraham edited the test plan for this revision. (Show Details)May 8 2018, 9:08 PM
apol accepted this revision.May 9 2018, 10:10 AM
This revision is now accepted and ready to land.May 9 2018, 10:10 AM
markg accepted this revision.May 9 2018, 12:46 PM
markg added a subscriber: markg.

Please do note that you have more protocols with shared folders that likely deserve a name change in the same fashion.

Which ones, and where do they live?

This revision was automatically updated to reflect the committed changes.
markg added a comment.May 9 2018, 1:15 PM

Which ones, and where do they live?

I would have expected it for NFS (same repository), but it apparently doesn't have a .desktop file at all.
FTP (lives in the mina kio repo in the ioslaves folder) could have been a possibility but also doesn't have a .desktop file.

So no others i suppose.