switch to elisa application icon and remove the workaround for icons
ClosedPublic
Actions

Authored by mgallien on May 6 2018, 4:18 PM.

Details

Reviewers

paullesur
ngraham

Group Reviewers

Elisa

Commits

R255:17cc656e97db: switch to elisa application icon and remove the workaround for icons

Summary

switch to elisa application icon and remove the workaround for icons

in some KF5 versions, we had icons not playing nice with Elisa so we
added a workaround for them, let's remove it and require a working
version of KF5

use the elisa icon for the application icon

Test Plan

icons look nice

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.May 6 2018, 4:18 PM

mgallien created this revision.

Much nicer!

This revision is now accepted and ready to land.May 6 2018, 4:55 PM

Closed by commit R255:17cc656e97db: switch to elisa application icon and remove the workaround for icons (authored by mgallien). · Explain WhyMay 6 2018, 6:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/localFileConfiguration/kcm_elisa_local_file.desktop (2 lines)
M			src/main.cpp (2 lines)
M			src/qml/MediaPlayListView.qml (2 lines)
M			src/qml/PlayListEntry.qml (2 lines)
M			src/qml/Theme.qml (2 lines)
M			src/windows/WindowsTheme.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33713	d41c7e0		May 6 2018, 4:18 PM	★	★
Diff 2	33718	d41c7e0	R255:17cc656e97db75bd79f0e58d07da3c866968bfd9	May 6 2018, 6:26 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
69ce0f317964	8e0d866aae68	d41c7e060227	Matthieu Gallien	switch to elisa application icon and remove the workaround for icons (Show More…)	May 6 2018, 4:09 PM