Differential D12706

Reparse rules config prior to update
ClosedPublic
Actions

Authored by graesslin on May 5 2018, 7:14 AM.

Details

Reviewers
romangg
Group Reviewers
KWin
Plasma
Commits
R108:bed31e055785: Reparse rules config prior to update
Summary

We used to recreate the KConfig when rules needed to update. Now that it
is a KSharedConfig, which is kept, it needs to be reparsed as it changes
outside of KWin.

BUG: 393788
FIXED-IN: 5.13.0

Test Plan

Restarted session, changing rules work again

Diff Detail

Repository
R108 KWin
Branch
rules-reparse
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.May 5 2018, 7:14 AM
Restricted Application added a project: KWin. · View Herald TranscriptMay 5 2018, 7:14 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.May 5 2018, 7:14 AM
romangg accepted this revision as: KWin, romangg.May 9 2018, 2:33 PM
romangg added a subscriber: romangg.

Not a huge issue, but put it in an else to !m_config (only reparse if the config wasn't opened right now, because I assume it's parsed when openConfig was called).

This revision is now accepted and ready to land.May 9 2018, 2:33 PM
Closed by commit R108:bed31e055785: Reparse rules config prior to update (authored by graesslin). · Explain WhyMay 20 2018, 1:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrules.cpp (1 line)

Diff 33671

View Options

rules.cpp

Loading...