Properly fix the native messaging host file
ClosedPublic

Authored by bshah on May 4 2018, 9:40 AM.

Details

Summary
  • Previous approch broke the installation for the non-root installation where make install was performed as user
  • Add option COPY_MESSAGING_HOST_FILE_HOME option to cmake configuration which allows to copy the host file to user specific paths where relevant applications look for.
Test Plan

tested on neon system by removing package installed path and doing make
install as normal user

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah created this revision.May 4 2018, 9:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 4 2018, 9:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah requested review of this revision.May 4 2018, 9:40 AM
davidedmundson accepted this revision.May 4 2018, 10:36 AM
This revision is now accepted and ready to land.May 4 2018, 10:36 AM
mwolff added a comment.May 4 2018, 4:55 PM

It compiles, how do I test it? Can you please also add a README to the root of this project that explains what this is, does and how to use it?

thanks

mwolff added a comment.May 7 2018, 6:56 PM

@bshah ping? will you push this?

bshah added a comment.May 9 2018, 6:57 AM

@bshah ping? will you push this?

sorry, I was on sick leave, I'll push this, however for documentation you will have to wait for @davidedmundson or @broulik as they are the one who knows the code and features. :-)

This revision was automatically updated to reflect the committed changes.