Fix sidebar view regression of not prompting about unsaved changes
ClosedPublic

Authored by davidedmundson on May 3 2018, 6:33 PM.

Details

Summary

When you switch module with unsaved changes the other modes prompt if
you want to save the changes. Sidebar mode did not.

BUG: 392160

Test Plan

Made a change, clicked another module. Got a prompt.

Clicked apply, it applied then changed

Tried again

Clicked cancel, it didn't change

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.May 3 2018, 6:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2018, 6:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.May 3 2018, 6:33 PM
broulik accepted this revision.May 4 2018, 6:41 AM
broulik added a subscriber: broulik.

The current index or highlighted item in the sidebar still changes if you Cancel in the prompt as that's done from QML

This revision is now accepted and ready to land.May 4 2018, 6:41 AM

Also fixes the UI on cancel

Checkable property would be updated internally on clicked, breaking our binding and
becoming checked on clicked regardless
The background color is set by if (checked || highlighted) so we can use that instead

Remove debug

stupid arc. Spend ages selectively choosing the hunks I want, and then it goes and adds them
back anyway to "help".

Remove debug

stupid arc. Spend ages selectively choosing the hunks I want, and then it goes and adds them
back anyway to "help".

This revision was automatically updated to reflect the committed changes.