Show SNI when software renderer is in use
ClosedPublic

Authored by davidedmundson on May 3 2018, 11:34 AM.

Details

Summary

This then invokes the relevant KCM when clicked

Test Plan

Forced software rendering, saw SNI
restarted, saw SNI
set "never show again". It hid itself
Restarted. It remained hidden

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.May 3 2018, 11:34 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2018, 11:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.May 3 2018, 11:34 AM

One of the requested features to D11722 just split as a separate review as the code is mostly unrelated

broulik added a subscriber: broulik.May 3 2018, 2:08 PM
broulik added inline comments.
shell/softwarerendernotifier.cpp
15

Returns empty string for me, as it's too early in the startup:

\note The return value of this function may still be outdated by
subsequent calls to setSceneGraphBackend() until the first QQuickWindow in the
application has been constructed.

(I verified with QSG_INFO that I'm running software)

29

This will cause that long text to show up as main text in huge font. Should probably use the subtext so the "Software Renderer In Use" is the tooltip main title

(Also, in some cases the software renderer is actually faster :P how about "performance might be reduced" or something like that?)

49

= default

davidedmundson added inline comments.May 3 2018, 2:14 PM
shell/softwarerendernotifier.cpp
15

We're not making any subsequent calls to setSceneGraphBackend so that should be fine

Did you set it through the KCM (and hence set in KQuickAddons::QtQuickSettings::init();) or through env vars?

Should this notifier provide some tip for user on how to go back to hardware rendering? Or is it not relevant here?

Should this notifier provide some tip for user on how to go back to hardware rendering? Or is it not relevant here?

I give them a KCM where they can easily toggle it back. That's only really useful after they've fixed their real problem, but I don't think we can really help with that.

I give them a KCM where they can easily toggle it back. That's only really useful after they've fixed their real problem, but I don't think we can really help with that.

Well, I mean, some hint like "Open system settings, go there ... toggle this ... " ?

Updated per comments

davidedmundson marked 4 inline comments as done.May 3 2018, 3:32 PM
broulik accepted this revision.May 3 2018, 3:35 PM
This revision is now accepted and ready to land.May 3 2018, 3:35 PM
This revision was automatically updated to reflect the committed changes.