Fix a few memory leaks, and some other minor fixes
Before:
After:
rkflx |
Fix a few memory leaks, and some other minor fixes
Before:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Thanks for fixing this ;)
LGTM (mostly).
src/Gui/KSWidget.cpp | ||
---|---|---|
35 ↗ | (On Diff #33513) | I know that sometimes there is the urge to fix "just another small thing". However, in general we prefer to stick to one topic/change per Diff, in order to keep the Git history somewhat clean. If you find it important enough to remove the include and demand your reviewer's time, send another Diff, otherwise just ignore it. We are aware that Spectacle's code is a bit messy in some parts. I admit it's very nitpicky, but please remove this change. |
@abalaji Congratulations, your first two patches are in. I guess the next ones won't be that easy ;)