MainWindow: Change comma position in initialization list
ClosedPublic
Actions

Authored by patrickelectric on May 2 2018, 6:53 PM.

Details

Reviewers

Commits

Summary

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

MainWindow: Move m_theme to initialization list

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

FileLoader: Move lastPerc inside file open function

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

Repository

R231 Atelier

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

patrickelectric requested review of this revision.May 2 2018, 6:53 PM

patrickelectric created this revision.

rizzitello added inline comments.

src/mainwindow.cpp
38	can we keep the commas where they were or change them in all files? Dont care what one but lets agree on one and use that way for all.

This revision is now accepted and ready to land.May 2 2018, 9:00 PM

src/mainwindow.cpp
38	comma after the variable will create two lines diff, a comma before the variable will create only one line diff. I'm only doing this here it was necessary to add a variable.

src/mainwindow.cpp
38	LOL ok

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/mainwindow.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33509	6c63158		May 2 2018, 6:53 PM	★	★
Diff 2	33537	6c63158	R231:025d38a5112af6a92be5bb7e9db31ffb2cf7bd76	May 2 2018, 5:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
101a80d841b7	6a76d0be0be1	ea1840a7f7d2	Patrick José Pereira	FileLoader: Move lastPerc inside file open function (Show More…)	May 2 2018, 6:48 PM
ea1840a7f7d2	568d1e261024	025d38a5112a	Patrick José Pereira	MainWindow: Move m_theme to initialization list (Show More…)	May 2 2018, 5:51 PM
025d38a5112a	aacecb688f13	6c63158fb344	Patrick José Pereira	MainWindow: Change comma position in initialization list (Show More…)	May 2 2018, 5:41 PM