| dkazakov |
| Krita |
This patch adds the ability to set the full clip start time and end time from the context menu. The result will be seen in the animation docker.
This mostly came about as I was working on an animation and frequently needed to change the end time. when making animations longer or adjusting the timings, changing the end time is pretty common. Other applications such as Blender and OpenToonz also have this so I think it is not a new concept.
Clicked the options and watched the animation docker update. it is currently the last 2 options in the current frame context menu. The data is saved in the animation model data, so I think I have all the data in sync.
| Lint Skipped |
| Unit Tests Skipped |
Hi, @scottpetrovic!
The patch is generally fine, I like the idea of auto-updating the the clip range. There are two small issues that should be fixed before pushing this to master:
I would propose the following solution: when multiple frames are selected, hide your two actions and show another one "Update Playback Range", which would reset both the limits in one go, by looking for the minimum and maximum selected columns. You can fetch the needed min/max metrics using TimelineFramesView::calculateSelectionMetrics().
| libs/image/kis_image_animation_interface.cpp | ||
|---|---|---|
| 163 | Please avoid debugging line in the final patch :) | |
| libs/ui/canvas/kis_animation_player.cpp | ||
| 240 | Why this code is needed? The animation player restarts itself automatically by connecting to the corresponding signal to slotUpdatePlaybackTimer() Or you try to update the animation docker via the player? | |
| plugins/dockers/animation/animation_docker.cpp | ||
| 122 | Is it possible to connect the docker directly to the image? Then the image play a role of "model" and the docker will play a role of "view" in model/view architecture. I don't fully understand why this forwarding via the animation player is needed. | |
thanks for the review @dkazakov
I think I got everything done with this. I removed the unnecessary function in the animation player so the docker talks directly to the animation interface.
I also added the set playback range functionality. That is a good idea. I also enabled the actions based on if there is a selection or not.
The patch looks and works fine now! Please push!
I would also propose hiding range-related context menu actions, when they are disabled. It would save a bit of space (I guess they are not too hot-used (my subjective opinion, I might be wrong)). But it is up to you to decide :)
Changes pushed out. If one frame is selected, only the options to set the start and end time exists. If multiple frames are selected, only the update playtime range action is shown.