Differential D12653

Remove Duplicate Filelists
ClosedPublic
Actions

Authored by rizzitello on May 2 2018, 1:17 AM.

Details

Reviewers
patrickelectric
tcanabrava
laysrodrigues
Commits
R231:84f59c1ea36a: Remove Duplicate filelists
R231:4b3a0e2be34b: Remove Duplicate Filelists
Summary

Every AtCoreInstance was getting a copy of the file list. This will remove the need to have the instance
get a copy.

Diff Detail

Repository
R231 Atelier
Branch
removeDupFileLists
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.May 2 2018, 1:17 AM
rizzitello created this revision.
tcanabrava added inline comments.May 2 2018, 9:12 AM
src/mainwindow.cpp
109

memleak man :)
create without the new.

src/widgets/atcoreinstancewidget.h
64

initiate privates in the initialization list.

rizzitello marked 2 inline comments as done.May 2 2018, 8:25 PM
rizzitello updated this revision to Diff 33518.May 2 2018, 8:25 PM
  • rebase / tomaz suggestions
patrickelectric accepted this revision.May 2 2018, 8:53 PM
This revision is now accepted and ready to land.May 2 2018, 8:53 PM
laysrodrigues accepted this revision.May 3 2018, 1:33 AM
rizzitello closed this revision.May 3 2018, 1:35 AM

Revision Contents
Changeset List

Diff 33534

View Options

src/mainwindow.cpp

Loading...
View Options

src/widgets/atcoreinstancewidget.h

Loading...
View Options

src/widgets/atcoreinstancewidget.cpp

Loading...