Differential D12623

[effects/maximize] Enable blur behind windows
ClosedPublic
Actions

Authored by anemeth on Apr 30 2018, 8:14 PM.

Details

Reviewers
graesslin
ngraham
Group Reviewers
KWin
VDG
Commits
R108:9644f29b8b53: [effects/maximize] Enable blur behind windows
Summary

Use the blur effect even while the window is being maximized/unmaximized.

Test Plan

Before:

After:

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anemeth created this revision.Apr 30 2018, 8:14 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 30 2018, 8:14 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
anemeth requested review of this revision.Apr 30 2018, 8:14 PM
anemeth edited the summary of this revision. (Show Details)Apr 30 2018, 8:16 PM
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: KWin, VDG.
anemeth updated this revision to Diff 33362.Apr 30 2018, 8:44 PM

Convert from binary to text

zzag added a subscriber: zzag.Apr 30 2018, 8:56 PM

Still binary.

anemeth added a comment.Apr 30 2018, 9:00 PM
In D12623#256172, @zzag wrote:

Still binary.

I know....
arc won't let upload it unless it's binary. It has a weird encoding.
Still trying to figure it out.

zzag added a comment.EditedApr 30 2018, 9:03 PM
In D12623#256175, @anemeth wrote:
In D12623#256172, @zzag wrote:

Still binary.

I know....
arc won't let upload it unless it's binary. It has a weird encoding.
Still trying to figure it out.

Change it to UTF-8. I had similar problems with this effect(well, copy of it, D9391).

anemeth added a comment.Apr 30 2018, 9:08 PM
In D12623#256176, @zzag wrote:

Change it to UTF-8. I had similar problems with this effect(well, copy of it, D9391).

I tried Kate and an online converter too. Still no luck.
How did you solve it?

zzag added a comment.Apr 30 2018, 9:16 PM
In D12623#256179, @anemeth wrote:

I tried Kate and an online converter too. Still no luck.
How did you solve it?

Check Telegram.

anemeth updated this revision to Diff 33364.Apr 30 2018, 9:53 PM

Convert to UTF-8

graesslin accepted this revision.May 1 2018, 9:26 AM
graesslin added a subscriber: graesslin.

Somehow I find it unbelievable that the new blur is fast enough. Really good work!

This revision is now accepted and ready to land.May 1 2018, 9:26 AM
ngraham accepted this revision.May 1 2018, 3:54 PM
ngraham added a subscriber: ngraham.

This looks really slick.

Closed by commit R108:9644f29b8b53: [effects/maximize] Enable blur behind windows (authored by anemeth). · Explain WhyMay 1 2018, 9:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33457

View Options

effects/maximize/package/contents/code/maximize.js

Loading...