Differential D12620

[effects/desktopgrid] Enable blur behind windows
ClosedPublic
Actions

Authored by anemeth on Apr 30 2018, 6:53 PM.

Details

Reviewers
davidedmundson
fredrik
graesslin
ngraham
Group Reviewers
VDG
KWin
Commits
R108:c3e84e107326: [effects/desktopgrid] Enable blur behind windows
Summary

Use the blur effect even when the desktop grid is used.

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anemeth created this revision.Apr 30 2018, 6:53 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 30 2018, 6:53 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
anemeth requested review of this revision.Apr 30 2018, 6:53 PM
anemeth edited the summary of this revision. (Show Details)Apr 30 2018, 6:55 PM
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: davidedmundson, fredrik, VDG.
anemeth retitled this revision from Enable blur for desktop grid effect to [effects/desktopgrid] Enable blur behind windows.Apr 30 2018, 7:59 PM
graesslin requested changes to this revision.May 1 2018, 9:25 AM
graesslin added a subscriber: graesslin.
graesslin added inline comments.
effects/desktopgrid/desktopgrid.cpp
166

please don't use foreach for new code. There is a risk that it gets removed in Qt 6, see https://www.kdab.com/goodbye-q_foreach/

use

for (auto w : qAsConst(effects->stackingOrder()))

instead

This revision now requires changes to proceed.May 1 2018, 9:25 AM
anemeth updated this revision to Diff 33393.May 1 2018, 2:14 PM
  • Merge branch 'master' of git://anongit.kde.org/kwin into desktopgrid_blur
  • Change foreach to for
anemeth added inline comments.May 1 2018, 2:17 PM
effects/desktopgrid/desktopgrid.cpp
166

qAsConst can't be used on functions, only variables. See: http://doc.qt.io/qt-5/qtglobal.html#qAsConst

AFAIK for (auto const &w : effects->stackingOrder()) also operates on references, without deep copying, like qAsConst.

graesslin accepted this revision.May 1 2018, 2:32 PM
This revision is now accepted and ready to land.May 1 2018, 2:32 PM
ngraham accepted this revision.May 1 2018, 3:54 PM
Closed by commit R108:c3e84e107326: [effects/desktopgrid] Enable blur behind windows (authored by anemeth). · Explain WhyMay 1 2018, 9:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33455

View Options

effects/desktopgrid/desktopgrid.h

Loading...
View Options

effects/desktopgrid/desktopgrid.cpp

Loading...