KFileWidget: Save places panel width also after hiding panel
ClosedPublic

Authored by rkflx on Apr 29 2018, 6:12 AM.

Details

Summary

In certain situations the user-set width of the places panel was not
remembered.

As placesViewWidth is initialized by configGroup.readEntry and
updated in reaction to user actions, it makes sense to also save the
same variable back to the config file, instead of looking directly at
the placesViewSplitter.

Depends on D12592

Ref T8552

FIXED-IN: 5.46

Test Plan

kdialog --getopenfilename, change width of places panel, hide places
panel with F9, close dialog by clicking on Cancel, reopen
dialog, close dialog a second time, reopen dialog, press F9 again
and check that previously set width is restored.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Apr 29 2018, 6:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 29 2018, 6:12 AM
rkflx requested review of this revision.Apr 29 2018, 6:12 AM
ngraham accepted this revision.Apr 30 2018, 3:21 AM
ngraham added a subscriber: ngraham.

Nice catch.

This revision is now accepted and ready to land.Apr 30 2018, 3:21 AM
This revision was automatically updated to reflect the committed changes.