On systems without the support for shared memory which sqlite wal
can not run on, just disable the sqlite plugin instead of killing KAMD.
Also, before we have a proper way to handle database corruption,
this will at least allow KAMD to be started in this case.
| No Linters Available |
| No Unit Test Coverage |
ivan created this revision.Sat, Apr 28, 2:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sun, Apr 29, 2:21 PM
I don't mind you merging if no-one bothers reviewing your changes, but expecting that in 24 hours is a bit ridiculous.
Also this commit contains some very irrelevant changes to your commit message (removing kde4 migration, plugin loading validation) please try to keep things split.
I pushed it by accident, and I didn't want to revert just to push it to the phab again. Though, I did count that you'll check it out in the end even if it is already merged :)
The plugin loading validation is tied to this - if the database can not be opened, the sqlite plugin needs to be disabled.
The kde4 thing could have been a separate patch.