Differential D12553

Convert loc() to function and add arguments checks
ClosedPublic
Actions

Authored by mglb on Apr 26 2018, 9:55 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:674de973f9d2: Convert loc() to function and add arguments checks
Summary

For debug builds, the function will fail when called with out of display
coordinates, allowing to spot addressing errors. For regular builds,
it will limit coordinates to valid area without triggering errors.

Depends on D12551

Test Plan
  • Compiles, does not fail with use cases from previous commit

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb requested review of this revision.Apr 26 2018, 9:55 PM
mglb created this revision.
hindenburg added a subscriber: hindenburg.May 21 2018, 9:13 PM

Can you rebase please?

mglb updated this revision to Diff 34613.May 21 2018, 9:52 PM

rebase master

Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptMay 21 2018, 9:52 PM
hindenburg accepted this revision.May 21 2018, 10:07 PM

Thanks, I've been trying to get rid of all the function #defines

This revision is now accepted and ready to land.May 21 2018, 10:07 PM
Closed by commit R319:674de973f9d2: Convert loc() to function and add arguments checks (authored by mglb, committed by hindenburg). · Explain WhyMay 21 2018, 10:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.h (2 lines)
Msrc/TerminalDisplay.cpp (13 lines)

Diff 34614

View Options

src/TerminalDisplay.h

Loading...
View Options

src/TerminalDisplay.cpp

Loading...