Fixed cases mainly come from the fact that ScreenWindow can be
larger that TerminalDisplay's image, and the way how selection area is
bounded (character's left edge, not first/last character in selection).
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:17cb78cee147: Prevent invalid image array indexing
- Compile with ASAN
- Turn on blinking cursor
- Slowly change window size to less than 1 line or less than 1 column
- If everything is still ok, run top or anything that generates longer output
Expected result: no overflows
- Random selections (normal/block/line/word):
- on screen in left/right direction
- on screen + in history
- selecting history up
- selecting history down
- first/last character → last/first character in the line
- first/last character → last/first character on the screen
- all above with wide characters
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Do you notice an extra blank column space on the far right of the terminal? With scrollbar on the right, there's a space between text and scrollbar.
Comment Actions
I've tried with custom and default konsole config, zsh with powerline as the shell. I don't have any additional space other than the area which is too narrow to be used as text column and part of the scrollbar. But those are normally there. I've tried displaying long text lines and long text lines + window scaling. TerminalCenter and TerminalMargin also works as in master.
Comment Actions
OK maybe it just strange the first time seeing it when using the window size from the old code. I'll double-check again.
Comment Actions
Some of the konsole/tests/boxes.txt look much worse after this commit. I tried various fonts.
Single width, double, triple and quadruple dash.
Double width, double, triple and quadruple dash.
Comment Actions
Font: Hack; also tested Ubuntu Mono. Checked in vim and cat.
The boxes look the same for me, both on master and master + the patch reverted:
Font: Hack; also tested Ubuntu Mono. Checked in vim and cat.
Can you upload a screenshot?
Comment Actions
Ok just remembered I changed my fonts.conf for some other testing; reverting it corrects the boxes.