Rework InlineMessages to address a number of issues
ClosedPublic
Actions

Authored by hein on Apr 25 2018, 1:15 PM.

Details

Reviewers

broulik
mart

Group Reviewers

Plasma

Commits

Summary

Rework the reveal animation to work multiple times (previously on Qt 5.10 the content would stay hidden on a second visible=true.
Fix height self-adjustment outside of layouts.
Fix warning from setting implicitWidth - InlineMessage users should manage always manage the width of InlineMessage (with a layout or any other way).
More correct padding around content item (background border width + one small spacing), makes InlineMessage a few px less tall overall.
Get rid of a binding loop for height (by no longer using Control. contentItem).
Overall simplify code a little bit.

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein requested review of this revision.Apr 25 2018, 1:15 PM

Fix the animating prop

Seems to work well in Kirigami gallery and the KCMs

In D12516#253611, @broulik wrote:

Seems to work well in Kirigami gallery and the KCMs

Gimme a +1 then! 😛

Expand documentation as requested by Marco.

Remove a now-unused bool prop.

This revision is now accepted and ready to land.Apr 25 2018, 2:09 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/controls/InlineMessage.qml (46 lines)
M			src/controls/templates/InlineMessage.qml (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33065	49c7645		Apr 25 2018, 1:15 PM	★	★
Diff 2	33066	49c7645	Fix the animating prop	Apr 25 2018, 1:22 PM	★	★
Diff 3	33069	49c7645	Expand documentation as requested by Marco.	Apr 25 2018, 1:59 PM	★	★
Diff 4	33072	49c7645	R169:60c9e44c2c6302fef73f608761d35d4c3ef7cd50	Apr 25 2018, 1:58 PM	★	★