Differential D12503

[Desktop Theme KCM] Adjust to changes in other KCMs
ClosedPublic
Actions

Authored by broulik on Apr 24 2018, 7:36 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:03f29a85739c: [Desktop Theme KCM] Adjust to changes in other KCMs
Summary
  • Implement undo delete feature
  • Introduce currentIndex property instead of indexOf() method
  • Make GHNS dialog window modal instead of application modal
  • Support drag and drop to install themes
  • Use InlineMessage for installation error/success notifications

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 24 2018, 7:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2018, 7:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 24 2018, 7:36 PM
davidedmundson accepted this revision.Apr 24 2018, 8:52 PM
This revision is now accepted and ready to land.Apr 24 2018, 8:52 PM
Closed by commit R119:03f29a85739c: [Desktop Theme KCM] Adjust to changes in other KCMs (authored by broulik). · Explain WhyApr 24 2018, 8:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33015

View Options

kcms/desktoptheme/kcm.h

Loading...
View Options

kcms/desktoptheme/kcm.cpp

Loading...
View Options

kcms/desktoptheme/package/contents/ui/main.qml

Loading...