Bump gradle version
ClosedPublic

Authored by nicolasfella on Apr 24 2018, 6:56 PM.

Details

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 24 2018, 6:56 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 24 2018, 6:56 PM
nicolasfella requested review of this revision.Apr 24 2018, 6:56 PM

I wonder; if we're updating the gradle plugin version, shouldn't we go to the latest stable version 3.1.2?

I wonder; if we're updating the gradle plugin version, shouldn't we go to the latest stable version 3.1.2?

That sound reasoable. I merely did what Android Studio suggested to me. Maybe it didn't suggest the latest version because Android Studio itself is not up-to-date (I've installed from flathub and apparently the newest version isn't there yet)

I wonder; if we're updating the gradle plugin version, shouldn't we go to the latest stable version 3.1.2?

That sound reasoable. I merely did what Android Studio suggested to me. Maybe it didn't suggest the latest version because Android Studio itself is not up-to-date (I've installed from flathub and apparently the newest version isn't there yet)

Yeah, that matches my experience (studio 3.0.1 will recommend plugin 3.0.1, etc.).

Mind, I just tried out version 3.1.2 - it doesn't seem to like the build environment:

* What went wrong:
A problem occurred evaluating root project 'kdeconnect-android'.
> Failed to apply plugin [id 'com.android.application']
   > Configuration on demand is not supported by the current version of the Android Gradle plugin since you are using Gradle version 4.6 or above. Suggestion: disable configuration on demand by setting org.gradle.configureondemand=false in your gradle.properties file or use a Gradle version less than 4.6.

That should be easy enough to resolve with a gradle.properties file, like as described by https://stackoverflow.com/a/49994951

philipc accepted this revision.Apr 27 2018, 12:39 AM

Anyway, I think this change is good enough for now. We can revisit the version later.

This revision is now accepted and ready to land.Apr 27 2018, 12:39 AM
This revision was automatically updated to reflect the committed changes.

Sent from Mail for Windows 10