Differential D12493

Require NetworkManager 1.4.0 and newer
ClosedPublic
Actions

Authored by jgrulich on Apr 24 2018, 10:10 AM.

Details

Reviewers

sitter

Group Reviewers

Frameworks

Commits

R282:d5d45a61e324: Require NetworkManager 1.4.0 and newer

Summary

NM 1.4.0 was released in 2016, even Debian stable has newer version in repositories
so it shouldn't be problem to require it. We can remove almost all checks for NM
versions and it will also simplify code for upcoming changes.

Diff Detail

Repository

R282 NetworkManagerQt

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

jgrulich created this revision.Apr 24 2018, 10:10 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 24 2018, 10:10 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

jgrulich requested review of this revision.Apr 24 2018, 10:10 AM

jgrulich added a reviewer: Frameworks.Apr 24 2018, 10:10 AM

sitter accepted this revision.Aug 30 2018, 10:57 AM

This revision is now accepted and ready to land.Aug 30 2018, 10:57 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptAug 30 2018, 10:57 AM

Closed by commit R282:d5d45a61e324: Require NetworkManager 1.4.0 and newer (authored by jgrulich). · Explain WhyAug 30 2018, 11:18 AM

This revision was automatically updated to reflect the committed changes.

You have missed the checks added in https://phabricator.kde.org/D11353, e.g. in src/dnsconfiguration.h

Also, the API documentation has a lot of @notes referencing NM < 1.2.0, 1.0.6, ...

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/settings/8021xsettingtest.cpp (4 lines)
M			autotests/settings/bridgesettingtest.cpp (4 lines)
M			autotests/settings/connectionsettingtest.cpp (13 lines)
M			autotests/settings/gsmsettingtest.cpp (6 lines)
M			autotests/settings/vpnsettingtest.cpp (5 lines)
M			autotests/settings/wiredsettingtest.cpp (9 lines)
M			autotests/settings/wirelesssettingtest.cpp (10 lines)
M			src/accesspoint.cpp (4 lines)
M			src/activeconnection.cpp (8 lines)
M			src/adsldevice.cpp (4 lines)
M			src/bluetoothdevice.cpp (4 lines)
M			src/bonddevice.cpp (4 lines)
M			src/bridgedevice.cpp (4 lines)
M			src/connection.cpp (5 lines)
M			src/devicestatistics.cpp (4 lines)
M			src/dhcp4config.cpp (5 lines)
M			src/dhcp6config.cpp (6 lines)
M			src/genericdevice.cpp (4 lines)
M			src/gredevice.cpp (4 lines)
M			src/infinibanddevice.cpp (4 lines)
M			src/iptunneldevice.cpp (4 lines)
M			src/macvlandevice.cpp (4 lines)
M			src/manager.cpp (5 lines)
M			src/modemdevice.cpp (8 lines)
M			src/olpcmeshdevice.cpp (4 lines)
M			src/settings.cpp (5 lines)
M			src/settings/bridgesetting.cpp (4 lines)
M			src/settings/connectionsettings.cpp (13 lines)
M			src/settings/gsmsetting.cpp (6 lines)
M			src/settings/security8021xsetting.cpp (4 lines)
M			src/settings/tunsetting.cpp (11 lines)
M			src/settings/vpnsetting.cpp (5 lines)
M			src/settings/wiredsetting.cpp (9 lines)
M			src/settings/wirelesssetting.cpp (9 lines)
M			src/teamdevice.cpp (4 lines)
M			src/tundevice.cpp (4 lines)
M			src/vethdevice.cpp (4 lines)
M			src/vlandevice.cpp (4 lines)
M			src/vpnconnection.cpp (4 lines)
M			src/wimaxdevice.cpp (4 lines)
M			src/wireddevice.cpp (4 lines)
M			src/wirelessdevice.cpp (4 lines)