Details

Reviewers

drosca
apol
davidedmundson

Commits

R994:0abe8778072a: Add dptr to models

Summary

Last exported classes without dptr

Test Plan

Builds

Diff Detail

Repository

R994 Pulseaudio Qt Bindings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Apr 23 2018, 9:41 PM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2018, 9:41 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

nicolasfella requested review of this revision.Apr 23 2018, 9:41 PM

Coding style

Add license header

broulik added a subscriber: broulik.Apr 23 2018, 9:48 PM

broulik added inline comments.

src/models.h
47	The `override` is sufficient
81	Why `void*`?
src/models_p.h
27	Do we need an explicit `Q_DECL_HIDDEN` or something?

nicolasfella added inline comments.Apr 23 2018, 10:00 PM

src/models.h
81	So we can replace it with a "real" private class when we need it without creating a empty one now

Remove unneeded modifier

nicolasfella marked an inline comment as done.Apr 23 2018, 10:01 PM

davidedmundson accepted this revision.Apr 30 2018, 9:11 AM

davidedmundson added a subscriber: davidedmundson.

davidedmundson added inline comments.

src/models_p.h
27	No. That's only needed for when people do class AbstractModel::Private where AbstractModel is exported

This revision is now accepted and ready to land.Apr 30 2018, 9:11 AM

Closed by commit R994:0abe8778072a: Add dptr to models (authored by nicolasfella). · Explain WhyApr 30 2018, 10:05 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/models.h (25 lines)
M		src/models.cpp (93 lines)
A	M	src/models_p.h (51 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32919	c102a76		Apr 23 2018, 9:41 PM	★	★
Diff 2	32920	c102a76	- Coding style	Apr 23 2018, 9:44 PM	★	★
Diff 3	32921	c102a76	- Add license header	Apr 23 2018, 9:45 PM	★	★
Diff 4	32924	c102a76	- Remove unneeded modifier	Apr 23 2018, 10:01 PM	★	★
Diff 5	33315	c102a76	R994:0abe8778072a85a512f3df33d7084c23a40410c6	Apr 30 2018, 10:04 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a1e3f6c9d5fb	e1d30147968d	cba5195e7b59	Nicolas Fella	Remove unneeded modifier	Apr 23 2018, 10:00 PM
cba5195e7b59	c488551ce8a9	4f3ae8ae7c5d	Nicolas Fella	Add license header	Apr 23 2018, 9:44 PM
4f3ae8ae7c5d	1356589132f7	7b5c36c92f93	Nicolas Fella	Coding style	Apr 23 2018, 9:43 PM
7b5c36c92f93	5412b10fb28b	c102a76c9538	Nicolas Fella	Add dptr to models (Show More…)	Apr 23 2018, 9:39 PM

Add dptr to models
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 33315

src/models.h

src/models.cpp

src/models_p.h

Add dptr to modelsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 33315

src/models.h

src/models.cpp

src/models_p.h

Add dptr to models
ClosedPublic
Actions

Revision Contents
Changeset List