Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces
ClosedPublic

Authored by sharvey on Apr 23 2018, 9:40 PM.

Details

Summary

Aligned detail item labels; added "Not Applicable" when PolicyKit info is missing

Test Plan
  • Apply patch
  • Kill and relaunch polkit-kde-authentication-agent-1
  • Launch an application or change a KCM that prompts for authorization
  • Check that details are no longer left blank

Diff Detail

Repository
R121 Policykit (Polkit) KDE Agent
Branch
polish-detail-panel (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
sharvey created this revision.Apr 23 2018, 9:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2018, 9:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sharvey requested review of this revision.Apr 23 2018, 9:40 PM

Before


After

A little UI polishing, just for the details panel. The redesign of the main dialog is still under discussion (T8569, D12311) so I touched up the details.

Does anyone know of an application that fills in the Application field? I haven't been able to find one. I also went down the rabbit hole on how PolicyKit is triggered and couldn't find a solution. It's always blank.

If there's a way to get hold of the application name that's asking for authorization, it would be nice to have access to. If nothing else, it belongs in the window titlebar.

sharvey edited the test plan for this revision. (Show Details)Apr 23 2018, 9:48 PM
sharvey added a reviewer: Plasma.
sharvey updated this revision to Diff 32938.Apr 24 2018, 12:43 AM
  • Turned off "glow" effect on vendor URL; was rendering strange transparency
davidedmundson accepted this revision.Apr 24 2018, 8:57 AM
This revision is now accepted and ready to land.Apr 24 2018, 8:57 AM

Since you're doing a lot of work in this repo, perhaps your next patch should be to ad an .arccconfig file! :)

This revision was automatically updated to reflect the committed changes.
sharvey added a subscriber: bruns.Apr 24 2018, 2:58 PM

Since you're doing a lot of work in this repo, perhaps your next patch should be to ad an .arccconfig file! :)

Hm, can your commit be undone? I need to push the update @bruns identified in R121:b340539eca13 - or should it just be a new revision?

Just open a new revision, it's easier.

bruns added a comment.Jun 20 2018, 3:10 PM

New revision with remaining tasks: D12498