Akonadiconsole: support incidences serialized in the binary format
ClosedPublic

Authored by dfaure on Apr 22 2018, 10:10 PM.

Details

Summary

This experiment shows, however, that the "raw payload" really isn't the
actual raw payload from the DB, but rather the deserialized payload,
serialized again, i.e. it's "raw" only if the serializer is
actually symmetrical...

For this reason I'm wondering if the "converted from binary" comment is
a good idea after all, it makes it sound like the raw payload in the DB
is in the binary format, even when it's not.

Test Plan

clicking on events in akonadiconsole, with KCALCORE_BINARY_SERIALIZER=1,
shows "converted from binary" for all events. Without this patch, it showed binary
garbage for all events.

Diff Detail

Repository
R199 Akonadi Console
Branch
Applications/18.04
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Apr 22 2018, 10:10 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2018, 10:10 PM
dfaure requested review of this revision.Apr 22 2018, 10:10 PM
dvratil accepted this revision.EditedApr 28 2018, 10:43 AM

Unfortunately we don't preserve the raw data received from the Akonadi server, so I don't see any way how to detect if the event really is stored in the DB in a binary form right now. I think it's still more useful this way than just looking at binary garbage.

This revision is now accepted and ready to land.Apr 28 2018, 10:43 AM
dfaure closed this revision.Apr 28 2018, 2:00 PM