ping

gentle ping. is this solution acceptable?

In D12443#278922, @astippich wrote:

gentle ping. is this solution acceptable?

See D13583

thanks for working on this, I will test the your changes.
how likely is it that we can require Kf 5.48 soon in baloo-widgets? it may be worth to land this one in the meantime or should I abandon this revision?

friendly ping. this still fixes a wrong unit until KFormat can be used.

In D12443#291262, @astippich wrote:

friendly ping. this still fixes a wrong unit until KFormat can be used.

KFormat::formatValue() just landed, but this will raise the requirements to KF 5.49.

In D13886 the requirements were set to the same as Dolphin, and it is currently at 5.43. Imho it would be better to add a compile time switch (afterwards)

I only bumped the min deps to be able to apply some coding standards and have better known build conditions, so the unit tests could be fixed to no longer fail.

Other than that no own stakes here, just a plain end user :)

Though looking at the KA18.08 release plan, dependency freeze date has been passed, so bumping the min kf version would no longer be possible.
https://community.kde.org/Schedules/Applications/18.08_Release_Schedule#Thursday.2C_July_12.2C_2018:_KDE_Applications_18.08_Dependency_Freeze

So a build time version switch seems to be the solution to approach, if you ask me.

Sorry for the long absence, I was on holiday. Can we agree on merging this patch for applications 18.08, and I will make a patch for 18.12 which uses the new capabilities of KFormat?

We froze translatable text on 19th July, see https://community.kde.org/Schedules

master branch if someone approves this.

ping. Would be great to finally land this fix (in master)

Gentle ping. It is only a change of a unit label after all :)

Can we please first answer this and this before going on with this? I feel they are just ignored without any reasonable explanation. Thanks.

In D12443#330771, @safaalfulaij wrote:

Can we please first answer this and this before going on with this? I feel they are just ignored without any reasonable explanation. Thanks.

I'm totally fine with implementing only the label change and not using KFormat if there are still concerns. This would be fully translatable.

Come on, it shouldn't take 5 month to implement a unit label fix.

In D12443#330771, @safaalfulaij wrote:

Can we please first answer this and this before going on with this? I feel they are just ignored without any reasonable explanation. Thanks.

I'll see what I can do.