KSMTP: remove dependency on KMime, by removing setMessage().
ClosedPublic
Actions

Authored by dfaure on Apr 22 2018, 9:18 AM.

Details

Reviewers

Commits

Summary

Update API DOX and unittest to use setData(QByteArray).
In practice, kmailtransport/plugins/smtp is already using that directly.

Test Plan

Compiles, unittest passes, all of kde/pim still compiles.

Repository

R733 KSmtp

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Apr 22 2018, 9:18 AM

Thanks for removing dead code.

This revision is now accepted and ready to land.Apr 22 2018, 9:20 AM

Improve unittest by actually testing the body too.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (4 lines)
M			KPimSMTPConfig.cmake.in (1 line)
M			Mainpage.dox (16 lines)
M			autotests/smtptest.cpp (16 lines)
M			src/CMakeLists.txt (3 lines)
M			src/sendjob.h (9 lines)
M			src/sendjob.cpp (47 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32767	8d8b015		Apr 22 2018, 9:18 AM	★	★
Diff 2	32769	8d8b015	Improve unittest by actually testing the body too.	Apr 22 2018, 9:34 AM	★	★
Diff 3	32777	8d8b015	R733:93a7777ae7dc618c26094f73a2c9e034a2a6f678	Apr 22 2018, 9:34 AM	★	★