Fix GrantleeTheme::ThemeManager being leaked.
ClosedPublic

Authored by dfaure on Apr 22 2018, 8:55 AM.

Details

Summary

When a Viewer was deleted, its ThemeManager was kept alive.
So it would still react to KDirWatch (when installing files) and it
would try to update a menu (QActionGroup) that was deleted with the
viewer.

BUG: 383070
FIXED-IN: 18.04

Test Plan

KMail, Enter to open separate viewer, Alt+F4, (uncommitted)
debug output shows that now the ThemeManager is deleted, while it wasn't before.

Diff Detail

Repository
R81 KDE PIM Addons
Branch
Applications/18.04
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Apr 22 2018, 8:55 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2018, 8:55 AM
dfaure requested review of this revision.Apr 22 2018, 8:55 AM
mlaurent accepted this revision.Apr 22 2018, 8:57 AM
This revision is now accepted and ready to land.Apr 22 2018, 8:57 AM
dfaure closed this revision.Apr 22 2018, 8:58 AM