Differential D12407

Article viewer: Use default profile so the font settings actually work
ClosedPublic
Actions

Authored by thomasbrixlarsen on Apr 21 2018, 1:54 PM.

Details

Reviewers
knauss
Commits
R201:b1a429407a64: Article viewer: Use default profile so the font settings actually work
Summary

Font settings minimum, medium, etc were never used because they were applied to a different QWebEngineProfile than the one used.

Diff Detail

Repository
R201 Akregator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a subscriber: KDE PIM. · View Herald TranscriptApr 21 2018, 1:54 PM
thomasbrixlarsen requested review of this revision.Apr 21 2018, 1:54 PM
knauss added a subscriber: knauss.Apr 21 2018, 3:17 PM

Can you explain, why we should do this? And what is the benefit of this patch?

thomasbrixlarsen added a comment.EditedApr 21 2018, 3:28 PM

Current situation:

  1. Change font settings.
  2. Articles shown using QWebEngine (load entire page) looks identical to before font setting change.

After patch:

  1. Change font settings.
  2. Articles shown using QWebEngine (load entire page) are shown with the new font settings.
knauss accepted this revision.Apr 21 2018, 5:23 PM

okay i get it.

Just a side question. As you have requested a bunch of reviews, do you have commit access for the repository? If not I can commit the patches for you.

This revision is now accepted and ready to land.Apr 21 2018, 5:23 PM
thomasbrixlarsen added a comment.Apr 21 2018, 5:40 PM

No I don't have commit access. Please go ahead.

Closed by commit R201:b1a429407a64: Article viewer: Use default profile so the font settings actually work (authored by thomasbrixlarsen, committed by knauss). · Explain WhyApr 21 2018, 8:35 PM
This revision was automatically updated to reflect the committed changes.
knauss added a comment.Apr 21 2018, 8:42 PM

Thanks for all these fixes from you. If you have any questions regarding developing please feel free to join #akonadi on IRC or use the mailinglist kde-pim@kde.org.
Especially as akregator has no real maintainer at the moment, so we will be very happy if people step up and take over mantainership.

Revision Contents
Changeset List

Diff 32738

View Options

src/articleviewer-ng/webengine/articleviewerwebengine.cpp

Loading...