Fix IMAP resource stuck if connection lost during Login.
ClosedPublic

Authored by dfaure on Apr 21 2018, 1:37 PM.

Details

Summary

If we lose the connection during the login job, we need to
make sure that connectionLost is emitted by the pool so that ResourceTask
will call cancelTask. Otherwise the resource will be stuck forever...

Test Plan

Initially, playing with switching between WIFI networks at the right time (difficult).
Then, calling SessionPool::onConnectionLost() by hand from LoginJob (great idea from Sandro).
Now tested by the new unittest.

Diff Detail

Repository
R44 KDE PIM Runtime
Branch
Applications/18.04
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Apr 21 2018, 1:37 PM
Restricted Application added a project: KDE PIM. ยท View Herald TranscriptApr 21 2018, 1:37 PM
dfaure requested review of this revision.Apr 21 2018, 1:37 PM
ervin accepted this revision.Apr 21 2018, 2:56 PM
This revision is now accepted and ready to land.Apr 21 2018, 2:56 PM
dfaure closed this revision.Apr 21 2018, 3:41 PM