Differential D12390

Do not resolve symlinks while collecting image files
ClosedPublic
Actions

Authored by tfry on Apr 20 2018, 8:47 PM.

Details

Reviewers
vonreth
kfunk
Commits
R138:bc3ca5e6c443: Do not resolve symlinks while collecting image files
Summary

This is where the flattened symlinks are really coming from.
Before breaking all packages on all platforms, I wanted you to have a look at
my patch, though.

Diff Detail

Repository
R138 Craft
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
tfry requested review of this revision.Apr 20 2018, 8:47 PM
tfry created this revision.
vonreth accepted this revision.Apr 20 2018, 9:05 PM

Wow thx.

This revision is now accepted and ready to land.Apr 20 2018, 9:05 PM
vonreth added inline comments.Apr 20 2018, 10:44 PM
bin/Packager/CollectionPackagerBase.py
229–232

I think we might have an extra check for `If isdir and islink``` ?

tfry added inline comments.Apr 21 2018, 6:37 AM
bin/Packager/CollectionPackagerBase.py
229–232

I believe it's needed. Symlinks to directories should not be recursed into, but they should be copied (unless blacklisted).

vonreth added inline comments.Apr 21 2018, 7:19 AM
bin/Packager/CollectionPackagerBase.py
229–232

Yes but the Qt build type filter ( only active on Windows in sdk mode) doesn't need to check folder symlinks

tfry updated this revision to Diff 32688.Apr 21 2018, 7:34 AM

Do not run directory symlinks through build type filter.

tfry updated this revision to Diff 32689.Apr 21 2018, 7:35 AM

Don't shortcuct.

tfry closed this revision.Apr 21 2018, 12:03 PM

Revision Contents
Changeset List

Diff 32689

View Options

bin/Packager/CollectionPackagerBase.py

Loading...