Differential D12379

[Containment Interface] Don't enter edit mode when immutable
ClosedPublic
Actions

Authored by broulik on Apr 20 2018, 12:20 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:a0b7a71a94a7: [Containment Interface] Don't enter edit mode when immutable
Summary

Opening the toolbox when widgets are locked reveals the widget handles but they're empty as all the actions are unavailable.
Just refuse to enter edit mode then.

Test Plan

Locked widgets, opened toolbox, applet handles stayed hidden. Same for system immutable.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 20 2018, 12:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 20 2018, 12:20 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Apr 20 2018, 12:20 PM
mart accepted this revision.Apr 22 2018, 10:48 AM
This revision is now accepted and ready to land.Apr 22 2018, 10:48 AM
Closed by commit R242:a0b7a71a94a7: [Containment Interface] Don't enter edit mode when immutable (authored by broulik). · Explain WhyApr 22 2018, 10:52 AM
This revision was automatically updated to reflect the committed changes.
broulik updated this revision to Diff 33071.Apr 25 2018, 2:14 PM
  • Also unset stupid Label height to avoid binding loops

Revision Contents
Changeset List

Diff 33071

View Options

src/declarativeimports/plasmastyle/ButtonStyle.qml

Loading...
View Options

src/declarativeimports/plasmastyle/ToolButtonStyle.qml

Loading...