Differential D12376

[ContextMenu Containment Action] Fix checking for KIOSK
ClosedPublic
Actions

Authored by broulik on Apr 20 2018, 11:15 AM.

Details

Reviewers
sitter
Group Reviewers
Plasma
Commits
R120:cfd77db90cf6: [ContextMenu Containment Action] Fix checking for KIOSK
Summary

Anyone else checks for run_command. Docs explicitly mention the fact that you have to also disable action/run_command for the menu entry to appear but this is a bit awkward, isn't it.
Also fix logout to check for the correct place as listed in documentation and other code places.

BUG: 393329
FIXED-IN: 5.15.5

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 20 2018, 11:15 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 20 2018, 11:15 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 20 2018, 11:15 AM
sitter added a comment.Apr 20 2018, 2:51 PM

The logout change seems fine.

WRT run_command I wonder if it wouldn't be better to keep this backwards compatible authorize(run_command) && authorizeAction(run_command). If a user previously restricted only actions/run_command that would, with the current diff, stop working.

broulik planned changes to this revision.Apr 22 2018, 10:58 AM
broulik updated this revision to Diff 32793.Apr 22 2018, 12:12 PM
  • Check both in run command
sitter accepted this revision.Apr 23 2018, 8:13 AM

LGTM now

This revision is now accepted and ready to land.Apr 23 2018, 8:13 AM
Closed by commit R120:cfd77db90cf6: [ContextMenu Containment Action] Fix checking for KIOSK (authored by broulik). · Explain WhyApr 23 2018, 1:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32883

View Options

containmentactions/contextmenu/menu.cpp

Loading...