When trying to overwrite a file using e.g. File → Save As
the confirmation dialog is duplicated.
This patch removes the additional Gwenview overwrite check since
QFileDialog shows its own dialog to confirm overwrite.
FIXED-IN: 18.04.1
ngraham | |
rkflx |
Gwenview |
When trying to overwrite a file using e.g. File → Save As
the confirmation dialog is duplicated.
This patch removes the additional Gwenview overwrite check since
QFileDialog shows its own dialog to confirm overwrite.
FIXED-IN: 18.04.1
Lint OK |
No Unit Test Coverage |
This bug was the reason for adding Gwenview's check: dc2188907b54.
KFileDialog did not support its own confirmation until v4.2: KFileDialog::setConfirmOverwrite(). After introduction it seems the default was disabled.
QFileDialog's confirmation dialog is default now: QFileDialog::Options.
I have nothing to add to the other reviewer's judgements :)
Also checked with XDG_CURRENT_DESKTOP=gnome gwenview, which is just fine. (Let's not forget when testing that for file dialog operations sometimes we can end up in GTK, which might handle things differently.)
Thanks for the analysis, saves time when reviewing!