Differential D12339

[KUrlNavigatorButton] Also don't stat MTP
ClosedPublic
Actions

Authored by broulik on Apr 19 2018, 7:08 AM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R241:73d2036b09a9: [KUrlNavigatorButton] Also don't stat MTP
Summary

Comment in the code says "leads to problems for protocols where a limit is given for the number of parallel connections." and KIO MTP is prone to misbehave because of that.

Test Plan

Breadcrumb bar still shows sane path, e.g.
"My Phone › Internal Storage › Some Folder"
and submenu list (click on triangle) also works

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 19 2018, 7:08 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 19 2018, 7:08 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Apr 19 2018, 7:08 AM
broulik retitled this revision from [KUrlNavigatorButton] Also don to [KUrlNavigatorButton] Also don't stat MTP.Apr 19 2018, 7:11 AM
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Frameworks.
ngraham accepted this revision.Apr 19 2018, 4:00 PM
This revision is now accepted and ready to land.Apr 19 2018, 4:00 PM
Closed by commit R241:73d2036b09a9: [KUrlNavigatorButton] Also don't stat MTP (authored by broulik). · Explain WhyApr 20 2018, 9:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32633

View Options

src/filewidgets/kurlnavigatorbutton.cpp

Loading...