Avoid infinite loops when fetching the URL from DocumentUrlDB
ClosedPublic

Authored by bruns on Apr 19 2018, 12:51 AM.

Details

Summary

Some users apparently have DBs which contain infinite loops in the idTree
(a parentId pointing to itself or one of its children). This manifests in
either crashes due to exhausted memory and/or the process being stuck
with 100% CPU load.

The problem can only be completely solved by either recreating the DB, or
by cleaning the DB from any problematic records. As in interim solution,
stop the code from crashing.

BUG: 378754
CCBUG: 385846
CCBUG: 391258
CCBUG: 393181

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 19 2018, 12:51 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 19 2018, 12:51 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bruns requested review of this revision.Apr 19 2018, 12:51 AM
bruns added a comment.Apr 27 2018, 7:44 PM

Can someone please review this - would be nice to get rid of all the bug reports and Baloo is shit, just disable it "reviews"

ngraham accepted this revision.Apr 27 2018, 7:56 PM
ngraham added a subscriber: ngraham.

Makes sense conceptually and doesn't break Baloo for me.

This revision is now accepted and ready to land.Apr 27 2018, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Is your report in bug https://bugs.kde.org/show_bug.cgi?id=364574 related to this diff? If so it could be marked as a duplicate.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 29 2018, 3:50 AM