Differential D12313

Consistently use text "Configure..." for applet configure buttons
ClosedPublic
Actions

Authored by kossebau on Apr 18 2018, 4:07 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R114:47feb15029da: Consistently use text "Configure..." for applet configure buttons
Summary

Applets which need initial configuration display some centered button
to noth indicate the status as well as help the user to quickly get
to the configuration page.

Having consistent text on those buttons improves UX.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 18 2018, 4:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 18 2018, 4:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 18 2018, 4:07 PM
kossebau added a comment.Apr 18 2018, 4:09 PM

Another applet which has such a button is the weather applet (master-only), which already uses this string.

There is some inconsistency though still: one button shows an icon, while the other two do not. This is due to QQC2 button not supporting an icon next to a text on a Button control. Ignore for now, or simply remove icon everywhere?

broulik accepted this revision.Apr 18 2018, 7:57 PM
broulik added a subscriber: broulik.

Can we fix configurationNeeded in the desktop/panel containment, please? :P

This revision is now accepted and ready to land.Apr 18 2018, 7:57 PM
Closed by commit R114:47feb15029da: Consistently use text "Configure..." for applet configure buttons (authored by kossebau). · Explain WhyApr 18 2018, 8:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32515

View Options

applets/comic/package/contents/ui/main.qml

Loading...
View Options

applets/mediaframe/package/contents/ui/main.qml

Loading...