Differential D12307

[mediaframe applet] Enable wrapping of fill mode description in config UI
ClosedPublic
Actions

Authored by kossebau on Apr 18 2018, 12:27 PM.

Details

Reviewers
aspotashev
Group Reviewers
Plasma
Commits
R114:b43a463230d0: [mediaframe applet] Enable wrapping of fill mode description in config UI
Summary

Especially with some translations the text will not fit on a single line.

BUG: 393232

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 18 2018, 12:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 18 2018, 12:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 18 2018, 12:27 PM
kossebau added a comment.Apr 18 2018, 12:29 PM

Target: Plasma/5.12 branch

I wonder if that mode description text should be there at all, given it is inconsistent with other places in Plasma config UI, which do not have such a separate info text item for the selection of the fill mode/positioning (e.g. image wallpaper config). But given there is enough space in the config page, and someone added it for some reason, let's for now ensure the full text is readable.

aspotashev accepted this revision.Apr 18 2018, 3:27 PM
aspotashev added a subscriber: aspotashev.

Should be good if it doesn't crash.

This revision is now accepted and ready to land.Apr 18 2018, 3:27 PM
Closed by commit R114:b43a463230d0: [mediaframe applet] Enable wrapping of fill mode description in config UI (authored by kossebau). · Explain WhyApr 18 2018, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32480

View Options

applets/mediaframe/package/contents/ui/ConfigGeneral.qml

Loading...