[mediaframe applet] Fix defunct adding of new files/folder per DnD
ClosedPublic
Actions

Authored by kossebau on Apr 17 2018, 4:33 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

It was broken for 2 reasons:

usage of since-renamed MediaFrame::has() method
calling push() directly on plasmoid.configuration.pathList was no-op due to QTBUG-67773

Test Plan

Dropping files & folders onto an existing mediaframe widget results in the
files & folders being added now.

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

kossebau requested review of this revision.Apr 17 2018, 4:33 PM

Target: 5.12 branch (drop not working is a regression compared to plasma4 version, also does applet indicate it supports the drop on hover)

This revision is now accepted and ready to land.Apr 17 2018, 4:36 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/mediaframe/package/contents/ui/main.qml (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32400	b3a0fe5		Apr 17 2018, 4:33 PM	★	★
Diff 2	32406	faa2650	R114:7a0b14bf13137b925be3a35c50889b7fef0faf77	Apr 17 2018, 4:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f960a34c493d	a321f5cd6d09	b3a0fe51436d	Friedrich W. H. Kossebau	[mediaframe applet] Fix defunct adding of new files/folder per DnD (Show More…)	Apr 17 2018, 4:31 PM