Clean up kwindecoration KCM qml code
ClosedPublic

Authored by davidedmundson on Apr 17 2018, 3:37 PM.

Details

Summary

Remove all instances of anchors in a layout.
This is undefined behaviour (even if it happens to work) and results in
a warning in 5.11.

Resulted in some shuffling about, but generally cleaner code.

Visually looks the same

Test Plan

Added some buttons
Dragged and dropped some buttons out of the top header
Still got my "drop here to remove button" hint with the same opacities

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 17 2018, 3:37 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 17 2018, 3:37 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
davidedmundson requested review of this revision.Apr 17 2018, 3:37 PM
broulik accepted this revision.Apr 18 2018, 9:55 AM
This revision is now accepted and ready to land.Apr 18 2018, 9:55 AM
This revision was automatically updated to reflect the committed changes.