Allow user to close left half of splitter.
ClosedPublic

Authored by rizzitello on Apr 16 2018, 8:33 PM.

Details

Summary

User can close the left split by clicking on the active widgets icon. Clicking on an icon agin will
show the widget. Having the Splitter close allows us to make a smaller minium size atelier for the user.

Open:


Closed:

Smallest Size:


Diff Detail

Repository
R231 Atelier
Branch
adjustUI
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Apr 16 2018, 8:33 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Apr 17 2018, 12:35 AM
  • Fix Button Selection
rizzitello edited the summary of this revision. (Show Details)Apr 17 2018, 12:46 AM
rizzitello edited the summary of this revision. (Show Details)
  • Cleaner logic
laysrodrigues added inline comments.Apr 17 2018, 11:27 AM
src/mainwindow.cpp
132

why? this just feels wrong

rizzitello marked an inline comment as done.Apr 17 2018, 11:31 AM
rizzitello added inline comments.
src/mainwindow.cpp
132

This is a work around to get the box unchecked. This is only needed because our buttons are all autoExclusive. This was the path of least resistance that provides the correct UX while perserving the UX for the toolbars exclusive buttons. We have other options but they all start with not having the buttonGroup have autoExclusivity and manually doing our own autoExclusive feature.

laysrodrigues accepted this revision.Apr 17 2018, 11:39 AM
This revision is now accepted and ready to land.Apr 17 2018, 11:39 AM
src/mainwindow.cpp
132

Can not use only btn->setChecked(false); btn->setCheckable(true); ?

rizzitello marked 2 inline comments as done.Apr 17 2018, 11:57 AM
rizzitello added inline comments.
src/mainwindow.cpp
132

you would think but it seams that unless I set it manually to unchecked its not really unchecked.. this might not matter now since we are no longer checking "checked" state here. i will try this again before merging.

src/mainwindow.cpp
132

Macro makes-bunny-cry:

rizzitello updated this revision to Diff 32425.Apr 17 2018, 8:36 PM
rizzitello marked an inline comment as done.
  • Rebase, Remove uncheck
rizzitello closed this revision.Apr 17 2018, 8:37 PM