[effects/magiclamp] Don't reset timeline
ClosedPublic

Authored by zzag on Apr 16 2018, 5:00 PM.

Details

Summary

Resetting timeline while animating a window causes some visual "glitches",
see videos below. Even though we can't use QTimer::toggleDirection,
that's safe to delete code which resets timeline because prePaintScreen
figures out correct direction of the timeline.

Before

After

Test Plan
  • Set duration to 5000
  • Furiously click an icon in the task manager

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Apr 16 2018, 5:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 16 2018, 5:00 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Apr 16 2018, 5:00 PM
zzag updated this revision to Diff 32308.Apr 16 2018, 5:13 PM

Wrong diff.

zzag edited the summary of this revision. (Show Details)Apr 16 2018, 5:15 PM
davidedmundson accepted this revision.Apr 19 2018, 9:49 PM
This revision is now accepted and ready to land.Apr 19 2018, 9:49 PM
This revision was automatically updated to reflect the committed changes.