Install okularpart with the rest of kparts
AbandonedPublic

Authored by apol on Apr 16 2018, 4:29 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Summary

We have a directory with all kparts, okular should integrate there

Test Plan

Uninstalled, installed with the patch applied, okular still works

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Apr 16 2018, 4:29 PM
Restricted Application added a project: Okular. · View Herald TranscriptApr 16 2018, 4:29 PM
apol requested review of this revision.Apr 16 2018, 4:29 PM
aacid requested changes to this revision.Apr 16 2018, 4:44 PM

This doesn't seem to work

statx(AT_FDCWD, "./okularpart.so", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7ffec9b97970) = -1 ENOENT (No such file or directory)
statx(AT_FDCWD, "./libokularpart.so", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7ffec9b97970) = -1 ENOENT (No such file or directory)
statx(AT_FDCWD, "/home/tsdgeos/devel/kde/install/lib64/plugins/okularpart.so", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7ffec9b97970) = -1 ENOENT (No such file or directory)
statx(AT_FDCWD, "/home/tsdgeos/devel/kde/install/lib64/plugins/libokularpart.so", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7ffec9b97970) = -1 ENOENT (No such file or directory)
statx(AT_FDCWD, "/usr/lib/qt/plugins/okularpart.so", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_ALL, stx_attributes=0, stx_mode=S_IFREG|0755, stx_size=1772608, ...}) = 0
openat(AT_FDCWD, "/usr/lib/qt/plugins/okularpart.so", O_RDONLY|O_CLOEXEC) = 9
openat(AT_FDCWD, "/usr/lib/qt/plugins/okularpart.so", O_RDONLY|O_CLOEXEC) = 9

It's loading the /usr part instead of the part in /home/tsdgeos/devel/kde/install/lib64/plugins/kf5/parts

This revision now requires changes to proceed.Apr 16 2018, 4:44 PM
apol updated this revision to Diff 32319.Apr 16 2018, 7:04 PM

Unsure why it worked for me, point to the library like katepart does

aacid added a comment.Apr 16 2018, 8:15 PM

I honestly don't see the need to install stuff in a non standard folder.

Why would this be a good idea?

Because "We have a directory with all kparts" it's not true, in my install only khtml and ktexteditor install into /usr/lib/qt/plugins/kf5/parts/ while ark, dolphin, gwenview, kmail, konsole, plasma-desktop (kfontviewpart), okular and okteta install into /usr/lib/qt/plugins

apol updated this revision to Diff 32347.Apr 17 2018, 12:14 AM

There's more desktop files pointing to okularpart

apol updated this revision to Diff 32348.Apr 17 2018, 12:15 AM

And another

apol updated this revision to Diff 32353.Apr 17 2018, 2:43 AM

The shell needs to know where the plugin is

aacid requested changes to this revision.May 24 2018, 9:48 AM
This revision now requires changes to proceed.May 24 2018, 9:48 AM
Restricted Application added a subscriber: okular-devel. · View Herald TranscriptMay 24 2018, 9:48 AM
apol abandoned this revision.Feb 11 2019, 4:14 PM