[Desktop Theme KCM] Port to new design
ClosedPublic

Authored by broulik on Apr 16 2018, 3:52 PM.

Details

Summary

The preview code could luckily be left completely untouched.

Test Plan
  • Verified that current index is correct upon opening
  • Verified that changing themes works
  • Verified that "open from file" works
  • Verified that GHNS works
  • Verified that edit theme works
  • Verified that theme removal works and is only enabled for deletable themes (and is now animated, the delegate zooms out like a plasmoid on the desktop) and then the other items move ot fill the gap


In case of error I used the new InlineMessage (before it would just show a small label next to the buttons)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 16 2018, 3:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 16 2018, 3:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 16 2018, 3:52 PM
broulik edited the test plan for this revision. (Show Details)
mart accepted this revision.Apr 16 2018, 3:54 PM
This revision is now accepted and ready to land.Apr 16 2018, 3:54 PM

This looks really good.

This revision was automatically updated to reflect the committed changes.