Add XDG Output support
ClosedPublic

Authored by davidedmundson on Apr 16 2018, 9:35 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Maniphest Tasks
T8501: Fractional Scaling
Commits
R108:1403fcf31685: Add XDG Output support
Test Plan

Very minimal expansion of unit tests which uses WaylandScreens
Wrote mini app to debug actual output of xdg-output for testing the DRM code

Main relevant user of this is xwayland > 1.20 which I don't have, so that
part remains untested

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Apr 16 2018, 9:35 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 16 2018, 9:35 AM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
davidedmundson requested review of this revision.Apr 16 2018, 9:35 AM

Just to clarify somethig, even though we need this for fractional scaling (which is quite a bit in the future) it's also needed to fix an xwayland fullscreen bug at regular 2x.
So I want this for 5.13 if possible

@bshah hwcomposer would also need adjustements, is that useful? Could we benefit from fractional scaling on hwcomposer?

Overall change looks good to me.

autotests/drm/objecttest.cpp
42 ↗(On Diff #32265)

typo?

@bshah hwcomposer would also need adjustements, is that useful? Could we benefit from fractional scaling on hwcomposer?

Quite possibly.
Though doing fractional scaling is effectively blocked on Qt 5.12, by which time Roman will have hopefully moved forward with his generic Output class. So it seems like it would be a waste for me to change now.

Remove stray char

graesslin accepted this revision.Apr 30 2018, 4:52 PM
This revision is now accepted and ready to land.Apr 30 2018, 4:52 PM

I tested this patch with Xwayland from master and it works very nice: Without the patch Neverball only shows left top 1/4 of its surface content with a 2x scaling. With the patch applied all its surface content is properly aligned to the screen.

Restricted Application removed a subscriber: KWin. · View Herald TranscriptMay 18 2018, 9:07 AM
This revision was automatically updated to reflect the committed changes.