Differential D12242

KJob public signals
ClosedPublic
Actions

Authored by jtamate on Apr 16 2018, 8:47 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R244:c0b312a41f7f: KJob public signals
Summary

KIO::KCoreDirLister connects to those signals, they must be public so the new connect syntax compiles.

Test Plan

kio compiles with new connect syntax.

Diff Detail

Repository
R244 KCoreAddons
Lint
Lint Skipped
Unit
Unit Tests Skipped
jtamate created this revision.Apr 16 2018, 8:47 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 16 2018, 8:47 AM
jtamate requested review of this revision.Apr 16 2018, 8:47 AM
dfaure requested changes to this revision.Apr 16 2018, 9:37 AM
dfaure added inline comments.
src/lib/jobs/kjob.h
472 ↗(On Diff #32258)

"can't" should now be "shouldn't", since it's now technically possible, just strongly discouraged.

If we leave "can't" and someone tries it, it will work, and they'll think there is no problem then ;)

This revision now requires changes to proceed.Apr 16 2018, 9:37 AM
jtamate updated this revision to Diff 32267.Apr 16 2018, 9:44 AM

Changed from "can't" to "shouldn't".

dfaure accepted this revision.Apr 16 2018, 10:00 AM
This revision is now accepted and ready to land.Apr 16 2018, 10:00 AM
Closed by commit R244:c0b312a41f7f: KJob public signals (authored by jtamate). · Explain WhyApr 16 2018, 5:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/jobs/kjob.h (18 lines)

Diff 32267

View Options

src/lib/jobs/kjob.h

Loading...