Differential D12241

Fix build with Qt 5.11_beta3 (dropping qt5_use_modules)
ClosedPublic
Actions

Authored by asturmlechner on Apr 15 2018, 11:37 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:11c3c06a45c3: Fix build with Qt 5.11_beta3 (dropping qt5_use_modules)
R319:977508bc17ed: Fix build with Qt 5.11_beta3 (dropping qt5_use_modules)
Test Plan

Built fine with Qt 5.11_beta3.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.Apr 15 2018, 11:37 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 15 2018, 11:37 PM
asturmlechner requested review of this revision.Apr 15 2018, 11:37 PM
hindenburg accepted this revision.Apr 17 2018, 2:21 PM
hindenburg added a subscriber: hindenburg.

thanks

This revision is now accepted and ready to land.Apr 17 2018, 2:21 PM
Closed by commit R319:11c3c06a45c3: Fix build with Qt 5.11_beta3 (dropping qt5_use_modules) (authored by asturmlechner). · Explain WhyApr 17 2018, 2:54 PM
This revision was automatically updated to reflect the committed changes.
hindenburg added a comment.Apr 17 2018, 3:08 PM

well I missed that you were using Applications/18.04 branch - typically I commit to master and backport bug fixes

Can you cherry-pick to master?

asturmlechner added a comment.Apr 17 2018, 3:47 PM
In D12241#248216, @hindenburg wrote:

well I missed that you were using Applications/18.04 branch - typically I commit to master and backport bug fixes

Usually fixes land in branches that are merged back to master.

Can you cherry-pick to master?

Sure!

hindenburg added a comment.Apr 18 2018, 12:27 AM

I'm not sure what other applications/frameworks does - last time I check the guidelines, it was up to maintainers. I'm just used to using master first as I try to make sure the current version branch is more stable.

Revision Contents
Changeset List

PathPackages
Mtools/CMakeLists.txt (2 lines)

Diff 32391

View Options

tools/CMakeLists.txt

Loading...