Save the view settings when the user closes the dialog using the excape key or the titlebar close button. Completes the feature requested in 209559.
CCBUG: 209559
Depends on D12227
davidedmundson |
Frameworks |
Save the view settings when the user closes the dialog using the excape key or the titlebar close button. Completes the feature requested in 209559.
CCBUG: 209559
Depends on D12227
Compile and deploy change, open Kate, open a file open or save dialog, change some settings, hit the escape key or the titlebar cancel button, then open a dialog again
No Linters Available |
No Unit Test Coverage |
src/platformtheme/kdeplatformfiledialoghelper.cpp | ||
---|---|---|
240 ↗ | (On Diff #32236) | typo: pressed |
src/platformtheme/kdeplatformfiledialoghelper.cpp | ||
---|---|---|
108 | Even better to me should be connect(this, &KDEPlatformFileDialog::rejected, m_fileWidget, &KFileWidget::slotCancel); PS: You can make a different review to change old syntax (SIGNAL/SLOT) to new function pointers. |
src/platformtheme/kdeplatformfiledialoghelper.cpp | ||
---|---|---|
108 | Sounds good, I will do that after this! |
...Gotta make sure that cancel slot actually works, so this is now dependent on my patch that fixes it: D12227