Reduce the number of zombies to a minimum
AbandonedPublic

Authored by tcberner on Apr 15 2018, 7:22 PM.

Details

Reviewers
sitter
apol
Group Reviewers
FreeBSD
Summary

With Frameworks 5.45 [1] when building for example plasma-workspace, I get
1000s of zombie processes, and the build hangs (burries zombies) for a long time.

Whith this change here, this is no longer the case.

[1] Probably from: https://phabricator.kde.org/D10776

Diff Detail

Repository
R249 KI18n
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
tcberner created this revision.Apr 15 2018, 7:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 15 2018, 7:22 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
tcberner requested review of this revision.Apr 15 2018, 7:22 PM
tcberner added inline comments.Apr 15 2018, 7:35 PM
cmake/build-pofiles.cmake
65

^ this is probalby the only required change.

tcberner updated this revision to Diff 32216.Apr 15 2018, 7:41 PM

Simplify the diff.

anthonyfieroni added inline comments.
cmake/build-pofiles.cmake
31

you can downgrade by 1 numberOfProcesses, BTW it's best value to have *alive* system.
PS: Probably you should check -1 if it's > 1

adridg added a subscriber: adridg.Apr 15 2018, 9:09 PM

Since you're using a global variable to accumulate ${numberOfProcesses} worth of po-files in one go, you should definitely clear out the variable when that bunch has been processed, or you'll grind through each po file more than once (with a growing command-list, too). You might consider the earlier version of the patch, which removes the global variable for a function parameter.

tcberner abandoned this revision.Apr 16 2018, 12:39 PM