Differential D12226

balooshow: Colorize only when attached to terminal
ClosedPublic
Actions

Authored by michaelh on Apr 15 2018, 3:42 PM.

Details

Reviewers
bruns
tcberner
Group Reviewers
Baloo
FreeBSD
Commits
R293:094d6e90d4c0: balooshow: Colorize only when attached to terminal
Test Plan
$ balooshow otto.txt
$ balooshow otto.txt | head -n 12

Diff Detail

Repository
R293 Baloo
Branch
no-color (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh created this revision.Apr 15 2018, 3:42 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 15 2018, 3:42 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
michaelh requested review of this revision.Apr 15 2018, 3:42 PM
bruns accepted this revision.Apr 15 2018, 11:27 PM
bruns added reviewers: bruns, FreeBSD.

LGTM
Can somebody FreeBSD folk confirm this works also on FreeBSD?

tcberner accepted this revision.Apr 16 2018, 5:51 AM
tcberner added a subscriber: tcberner.

Works as intended on FreeBSD.

This revision is now accepted and ready to land.Apr 16 2018, 5:51 AM
Closed by commit R293:094d6e90d4c0: balooshow: Colorize only when attached to terminal (authored by michaelh). · Explain WhyApr 16 2018, 8:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tools/balooshow/main.cpp (11 lines)

Diff 32256

View Options

src/tools/balooshow/main.cpp

Loading...