On e.g. openSUSE 15.0, which has 5.9 as default Qt, bold/italic/... styles no longer work.
The styleName() property overwrites them.
My patch just patches that away before setting the font.
That seems to work fine.
Details
Details
- Reviewers
dhaumann - Group Reviewers
Frameworks Kate - Commits
- R39:4d91fa7e918d: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9
Without patch: e.g. no bold if() constructs in C++ after setting the font once over the font chooser.
With patch: sane styling again.
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Btw there are bug reports for this. Could you link the Kate related ones, if existing?
Comment Actions
Btw there are bug reports for this. Could you link the Kate related ones, if existing?
I failed to find them :(
I remembered that this was brought up some time ago, but I had no time to take a look at that time.
And now I no longer find the mails/bugs :P
Comment Actions
Git commit 4d91fa7e918d983e6569798dfe20c7c9faf4bb9e by Christoph Cullmann.
Committed on 15/04/2018 at 11:36.
Pushed by cullmann into branch 'master'.
Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9
CHANGELOG: Fix missing bold/italic/... markup with modern Qt versions (>= 5.9)
Differential Revision: https://phabricator.kde.org/D12221
Comment Actions
See:
- https://bugs.kde.org/show_bug.cgi?id=376094
- https://bugs.kde.org/show_bug.cgi?id=383665
- https://bugs.kde.org/show_bug.cgi?id=387401
- https://bugs.kde.org/show_bug.cgi?id=391040
They all are closed as a general KFontChooser issue. Maybe we should even blog about this :p
Comment Actions
Perhaps the fix is only a hack, but at least it solves the issue for me on my company workstation ;=)
I was confused what did look strange after the upgrade, until I noticed the missing bold keywords.
Comment Actions
Nice fix, but it would be a shame if every client needs to work around this in the same way. I'm still holding out hope for a fix to KFontRequester, if possible.
Comment Actions
@dhaumann Please note that Phabricator review closing can take a few minutes to be processed.
Comment Actions
I have no idea, sorry. The issue is honestly too complicated for me to understand at this point. @rjvbb would be able to explain it better than I.
Comment Actions
Actually, no. I haven't been following that part at all (and am taking 2 weeks off of intensive dev stuff ;) )